docs(pre-requisites): change the RouterModule addition#539
Merged
SanderElias merged 1 commit intoscullyio:masterfrom May 13, 2020
geromegrignon:master
Merged
docs(pre-requisites): change the RouterModule addition#539SanderElias merged 1 commit intoscullyio:masterfrom geromegrignon:master
SanderElias merged 1 commit intoscullyio:masterfrom
geromegrignon:master
Conversation
- move up the warning about routermodule pre-requisites.md - remove the schematci command to add a routing module - add --routing to the existing creation commands
SanderElias
approved these changes
May 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What is the current behavior?
The schematic listed into the documentation
ng generate module app-routing --flat --module=appadds a module without RouterModuleWhat is the new behavior?
Close #534
Does this PR introduce a breaking change?